fix: auth integration test #41
Merged
+23
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes authentication integration tests by updating test database references and ensuring proper test data setup. The changes address inconsistencies in database naming and missing required fields that were causing test failures.
- Updated database references from
nginx_love_testtonginx_waf_testfor consistency - Added missing
isFirstLoginfield to test user data models - Enhanced JWT refresh token generation with unique JWT IDs for better security
- Created comprehensive test environment configuration
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/api/vitest.setup.ts | Updated test database name reference in error message |
| apps/api/src/utils/jwt.ts | Added JWT ID generation to refresh tokens for uniqueness |
| apps/api/src/domains/auth/tests/auth.service.test.ts | Added missing isFirstLogin field and updated refresh token test expectations |
| apps/api/src/domains/auth/tests/auth.integration.test.ts | Added missing isFirstLogin field to test user creation |
| apps/api/.env.test | Created comprehensive test environment configuration file |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.