Feature: Container Support (#37) #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat_docker: add Nginx with ModSecurity installation and configuration with container - Created pnpm workspace configuration for package management. - Added a script to install Nginx with ModSecurity from source, including all necessary dependencies and configurations. - Implemented a start script to launch Nginx and Node.js API. - Introduced Turbo configuration for task management, including build, dev, lint, test, and clean tasks. * refactor: streamline .env.example by removing unnecessary comments and consolidating configuration settings * refactor: update Dockerfile and docker-compose to use env_file and correct file paths * feat: enhance startup script to ensure Postgres readiness before starting Node.js API * Implement code changes to enhance functionality and improve performance * docker support * feat: add pnpm workspace configuration and turbo.json for task management - Created pnpm-workspace.yaml to define package structure for pnpm. - Added turbo.json to manage build, dev, lint, test, and clean tasks with dependencies. - Implemented a Docker installation script for Ubuntu/Debian systems, including Docker Compose setup. * Add database configuration to .env.example Added database configuration variables for DB name, user, and password. * feat: enhance Nginx configuration management keepalive * fix: update ModSecurity and ModSecurity-nginx repository URLs to the official OWASP sources * fix: update ModSecurity and ModSecurity-nginx repository URLs to the official OWASP sources
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive container support to the Nginx with ModSecurity project, introducing Docker-based deployment alongside the existing native installation methods. The changes include workspace configuration, build optimization, and containerized services for both frontend and backend components.
Key changes:
- Added complete Docker containerization with multi-service architecture (PostgreSQL, backend API, frontend)
- Implemented pnpm workspace configuration with Turbo for efficient monorepo task management
- Updated repository URLs from SpiderLabs to official OWASP sources for ModSecurity components
Reviewed Changes
Copilot reviewed 29 out of 41 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/install-nginx-modsecurity.sh | Updated ModSecurity repository URLs to OWASP official sources |
| scripts/deploy.sh | Added comprehensive Nginx configuration management with backup and validation |
| docker/* | Complete Docker infrastructure including Dockerfiles, compose files, and installation scripts |
| apps/api/src/* | Updated API services to work in containerized environments with improved Nginx management |
| config/nginx.conf | Restructured from simple server block to full Nginx configuration with ModSecurity |
| .env.example | Added comprehensive environment configuration template |
Comments suppressed due to low confidence (2)
docker/scripts/install-nginx-modsecurity.sh:1
- This line contains what appears to be a sensitive token or key that should not be committed to the repository. Consider removing this line and using environment variables or secure configuration management instead.
#!/bin/bash
docker/scripts/install-nginx-modsecurity.sh:1
- This line also contains what appears to be the same sensitive token or key. This should be removed from the committed code and handled through secure configuration management.
#!/bin/bash
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| running: stdout.includes('active (running)'), | ||
| output: stdout, | ||
| }; | ||
| if (stdout.trim() === "true") { |
There was a problem hiding this comment.
There are two spaces between '===' and '"true"'. This should be a single space for consistent formatting.
Suggested change
| if (stdout.trim() === "true") { | |
| if (stdout.trim() === "true") { |
Backup existing nginx configuration before updating it and test the new configuration. Restore from backup if the test fails.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: streamline .env.example by removing unnecessary comments and consolidating configuration settings
refactor: update Dockerfile and docker-compose to use env_file and correct file paths
feat: enhance startup script to ensure Postgres readiness before starting Node.js API
Implement code changes to enhance functionality and improve performance
docker support
feat: add pnpm workspace configuration and turbo.json for task management
Added database configuration variables for DB name, user, and password.
feat: enhance Nginx configuration management keepalive
fix: update ModSecurity and ModSecurity-nginx repository URLs to the official OWASP sources
fix: update ModSecurity and ModSecurity-nginx repository URLs to the official OWASP sources