feat: Add confirmation dialogs for delete actions in ACL, Alerts, SSL, User #31
+175
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and Users components
There was a problem hiding this comment.
Pull Request Overview
This PR adds confirmation dialogs for delete actions across the application to improve user experience and prevent accidental deletions. The changes replace simple browser confirm dialogs with a more user-friendly custom confirmation dialog component.
Key changes:
- Enhanced the ConfirmDialog component to support loading states, destructive variants, and React node descriptions
- Replaced browser confirm dialogs with custom confirmation dialogs in Users, SSL, Alerts, and ACL management pages
- Added proper state management for tracking items to be deleted
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/web/src/components/ui/confirm-dialog.tsx | Enhanced with loading spinner, destructive variant, and React node description support |
| apps/web/src/components/pages/Users.tsx | Added confirmation dialog for user deletion with detailed warning message |
| apps/web/src/components/pages/SSLTable.tsx | Replaced browser confirm with custom dialog for SSL certificate deletion |
| apps/web/src/components/pages/Alerts.tsx | Added confirmation dialogs for both notification channels and alert rules deletion |
| apps/web/src/components/pages/ACL.tsx | Added confirmation dialog for ACL rule deletion with access control warning |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.