-
Notifications
You must be signed in to change notification settings - Fork 0
update key in header #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @vncloudsco, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the API key authentication process by standardizing the header name from 'X-API-Key' to 'key'. This change simplifies the integration experience for external services and ensures that all user-facing messages and internal documentation accurately reflect the updated header requirement. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request changes the API key header from X-API-Key to key. This is a breaking change for any clients using API key authentication. My main feedback is that key is a very generic header name and it's generally better to use a more descriptive and conventional name like X-API-Key or a custom one like OVPanel-API-Key. I've left a specific suggestion to revert this change or choose a more descriptive name. Since this is a breaking change, it would be good to add a description to the pull request explaining the change and the reason for it.
|
|
||
| # API Key security scheme for Swagger UI | ||
| api_key_header = APIKeyHeader(name="X-API-Key", auto_error=False) | ||
| api_key_header = APIKeyHeader(name="key", auto_error=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API key header name has been changed from X-API-Key to key. While the X- prefix for custom headers is being deprecated, X-API-Key is a widely understood de-facto standard. Using a generic name like key is not recommended as it is not descriptive and could potentially conflict with other headers. It is better to use a more specific name. If you want to avoid the X- prefix, consider a name like OVPanel-API-Key. Reverting to X-API-Key would be the clearest and most conventional choice.
| api_key_header = APIKeyHeader(name="key", auto_error=False) | |
| api_key_header = APIKeyHeader(name="X-API-Key", auto_error=False) |
No description provided.