Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Platform Option #9

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Add Platform Option #9

merged 2 commits into from
Oct 11, 2023

Conversation

tinder-cwybranowski
Copy link
Contributor

Description

Add explicit platform option to CreateProvisioningProfileCommand, to enable consumers to inject the intended platform type for their underlying targets.

Changelog

  • IMPROVED:
    • iTunesConnectService.determineBundleIdITCId(...) with platform parameter
    • CreateProvisioningProfileCommand with platform option
  • FIXED:
    • Tests

tinder-maxwellelliott
tinder-maxwellelliott approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@tinder-maxwellelliott tinder-maxwellelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this oversight!

@tinder-maxwellelliott tinder-maxwellelliott merged commit 99f4a1d into Tinder:main Oct 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinder-maxwellelliott tinder-maxwellelliott tinder-maxwellelliott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinder-cwybranowski @tinder-maxwellelliott