Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add injectable platform support for macOS #3

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

tinder-calebdavis
Copy link
Contributor

@tinder-calebdavis tinder-calebdavis commented Jun 7, 2023

Injecting the platform to add support for macOS in the filter[platform] query param.

Note

This field supports an array of Strings so we could potentially extend sign-here to support more than one platform at a time.

Screenshot 2023-06-07 at 2 45 09 PM

Copy link
Collaborator

@tinder-maxwellelliott tinder-maxwellelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tinder-maxwellelliott tinder-maxwellelliott merged commit 9c80e39 into Tinder:main Jun 21, 2023
@tinder-calebdavis tinder-calebdavis deleted the mac_os_support branch June 21, 2023 20:56
andres97medrano pushed a commit to andres97medrano/sign-here that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants