Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Automatic profile regeneration #22

Merged
merged 15 commits into from
Jun 4, 2024

Conversation

omarzl
Copy link
Contributor

@omarzl omarzl commented May 31, 2024

This pr adds the feature proposed here #21

What changes:

  • If the argument profileName exists, a request to the API will consult if there is a profile with that name.
  • In case the profile exists, the flag --auto-regenerate is set and the number of devices changed, the profile will be deleted and created again with all the device ids.
  • In case the profile exists but the flag --auto-regenerate isn't set, then the profile will be saved to the outputPath and the process will exit successfully.
  • Since this new flag needs the profileName, a new error profileNameMissing will be triggered when the profile name doesn't exist.
  • The logic in the class iTunesConnectServiceImp that determines if the profile should register devices has been moved to the enum ProfileType so it can be reused in CreateProvisioningProfileCommand

Copy link
Collaborator

@tinder-maxwellelliott tinder-maxwellelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great

@tinder-maxwellelliott tinder-maxwellelliott merged commit 008bbad into Tinder:main Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants