-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Automatic profile regeneration #22
Merged
tinder-maxwellelliott
merged 15 commits into
Tinder:main
from
omarzl:task/regenerate-profile
Jun 4, 2024
Merged
[Feature] Automatic profile regeneration #22
tinder-maxwellelliott
merged 15 commits into
Tinder:main
from
omarzl:task/regenerate-profile
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great
Sources/SignHereLibrary/Commands/CreateProvisioningProfileCommand.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the feature proposed here #21
What changes:
--auto-regenerate
is set and the number of devices changed, the profile will be deleted and created again with all the device ids.--auto-regenerate
isn't set, then the profile will be saved to theoutputPath
and the process will exit successfully.profileNameMissing
will be triggered when the profile name doesn't exist.iTunesConnectServiceImp
that determines if the profile should register devices has been moved to the enumProfileType
so it can be reused inCreateProvisioningProfileCommand