Skip to content

Feature/fix overflowing ad display #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thinkjrs merged 4 commits into from
Feb 20, 2024
Merged

Feature/fix overflowing ad display #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d21b46
:art: add text truncate and block display styling to link
thinkjrs Feb 20, 2024
92f8823
:bug: add fixed width block display to parent span to stop overflow
thinkjrs Feb 20, 2024
c546553
:art: :recycle: add animation duration on link hover
thinkjrs Feb 20, 2024
b6c9fe1
:wrench: fix with linter
thinkjrs Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/components/AdDisplay/AdDisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,13 @@ function Ad({
)}
</a>
<div className="promo-button-ad-display-second-half-container">
<span>
<button className="promo-button-ad-display-target-link">
<span className="promo-w-[335px] promo-block">
<a
href={target || `https://tincre.com`}
className="promo-button-ad-display-target-link"
>
{target || `https://tincre.dev/promo`}
</button>
</a>
</span>
<div className="promo-flex promo-pt-4 promo-items-center promo-group promo-transition promo-transition-150 promo-select-none">
<span className="promo-button-ad-display-cta">
Expand Down
2 changes: 1 addition & 1 deletion src/styles/default.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@
@apply promo-uppercase promo-text-clip promo-font-bold promo-text-sm group-hover:promo-animate-pulse;
}
.promo-button-ad-display-target-link {
@apply promo-pt-2 promo-text-xs promo-text-gray-500 hover:promo-font-bold hover:promo-underline dark:promo-text-slate-400;
@apply promo-block promo-truncate promo-pt-2 promo-text-xs promo-text-gray-500 hover:promo-font-bold hover:promo-underline dark:promo-text-slate-400 promo-transition promo-duration-300 hover:promo-duration-300 promo-ease-in-out hover:promo-scale-105;
}
.promo-button-ad-display-second-half-container {
@apply promo-bg-gray-200 promo-pb-3 promo-px-2 dark:promo-bg-slate-900 dark:promo-text-slate-200;
Expand Down