Disconnect the connection after sending N un-acked packets#234
Conversation
kstrafe
force-pushed
the
sequenced-pathological-disconnect
branch
2 times, most recently
from
b861dc0 to
35eb8de
Compare
jstnlef
left a comment
jstnlef
left a comment
There was a problem hiding this comment.
Nice 👍. The only comment I have is maybe we should make the default something smaller?
|
@jstnlef What do you propose? This value is basically a "disable" value as it stands. |
kstrafe
force-pushed
the
sequenced-pathological-disconnect
branch
from
35eb8de to
d7b1174
Compare
|
What about 512? Less than 20 seconds at 30 Hz send rate. Let's it be generous without being too soon. |
kstrafe
force-pushed
the
sequenced-pathological-disconnect
branch
from
d7b1174 to
365c16b
Compare
|
Sounds good |
The connection is disconnected if we have N packets-in-flight simultaneously. Under normal usage we expect packets to be acked regularly so that our packets-in-flight size is relatively small.
|
Had to abort the build (sorry -- the build agent got stuck and had to be restarted). I think you have to push another commit to restart a build. |
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 97.57% 97.53% -0.04%
==========================================
Files 25 25
Lines 2554 2597 +43
==========================================
+ Hits 2492 2533 +41
- Misses 62 64 +2
Continue to review full report at Codecov.
|
|
Codecov is just complaining about panics not being triggered in a test. |
…#234) The connection is disconnected if we have N packets-in-flight simultaneously. Under normal usage we expect packets to be acked regularly so that our packets-in-flight size is relatively small.
The connection is disconnected if we have N packets-in-flight simultaneously. Under normal usage we expect packets to be acked regularly so that our packets-in-flight size is relatively small.
4 participants
The connection is disconnected if we have N packets-in-flight
simultaneously. Under normal usage we expect packets to be acked
regularly so that our packets-in-flight size is relatively small.