Skip to content

tests: Add missing asserts#226

Merged
TimonPost merged 1 commit intoTimonPost:masterfrom
kstrafe:missing-asserts
Aug 11, 2019
Merged

tests: Add missing asserts#226
TimonPost merged 1 commit intoTimonPost:masterfrom
kstrafe:missing-asserts

Conversation

@kstrafe
Copy link
Contributor

@kstrafe kstrafe commented Aug 9, 2019

Some asserts were missing on is_ok and is_none statements. This patch adds those asserts.

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #226 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          25       25           
  Lines        2357     2357           
=======================================
  Hits         2298     2298           
  Misses         59       59
Impacted Files Coverage Δ
src/packet/header/fragment_header.rs 98.07% <100%> (ø) ⬆️
src/packet/header/standard_header.rs 98.59% <100%> (ø) ⬆️
src/packet/header/acked_packet_header.rs 98.07% <100%> (ø) ⬆️
src/infrastructure/arranging/ordering.rs 99.09% <100%> (ø) ⬆️
src/packet/header/arranging_header.rs 97.67% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8c65f...c41a6e2. Read the comment docs.

Copy link
Contributor

@jstnlef jstnlef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@TimonPost TimonPost merged commit 6a86f50 into TimonPost:master Aug 11, 2019
jstnlef pushed a commit to jstnlef/laminar that referenced this pull request Oct 12, 2019
jstnlef pushed a commit that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants