Make Buffer::push_into private#649
Merged
frankmcsherry merged 1 commit intoTimelyDataflow:masterfrom Feb 26, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw a crash where a flushing buffer had data in its container, but had not been initialized with a time yet. This suggests that either the container's
is_emptymethod is wrong, or that we sneaked data into the container not through a session (or something else, but local inspection suggests that these are private fields that can only be accessed through sessions, except for thePushIntoimplementation).This shouldn't fix any bugs, as much as smoke out potentially incorrect usage of these buffers.