Remove columnation and flatcontainer deps#647
Merged
frankmcsherry merged 1 commit intoTimelyDataflow:masterfrom Feb 18, 2025
Merged
Remove columnation and flatcontainer deps#647frankmcsherry merged 1 commit intoTimelyDataflow:masterfrom
frankmcsherry merged 1 commit intoTimelyDataflow:masterfrom
Conversation
Remove the dependencies on columnation and flatcontainer as far as possible. This removes the TimelyStack type because it's not used in Timely and only retains the columnation implementation for Product. Flatcontainer was only used as an example, and we don't have any downstream dependencies on it left. Support for columnation and flatcontainer can be added by downstream crates if they chose to do so. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
added a commit
to antiguru/differential-dataflow
that referenced
this pull request
Feb 18, 2025
Adjust to changes in TimelyDataflow/timely-dataflow#647 which removes flatcontainer and columnation as Timely doesn't have any opinion around the types and defers to downstream crates instead. Ideally, we'd move the TimelyStack to an example, but that would be a bigger change, so I'm holding off for the moment. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
added a commit
to antiguru/differential-dataflow
that referenced
this pull request
Feb 18, 2025
Adjust to changes in TimelyDataflow/timely-dataflow#647 which removes flatcontainer and columnation as Timely doesn't have any opinion around the types and defers to downstream crates instead. Ideally, we'd move the TimelyStack to an example, but that would be a bigger change, so I'm holding off for the moment. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Member
|
Looks good, and quite a tidy; thank you! |
Merged
frankmcsherry
pushed a commit
to TimelyDataflow/differential-dataflow
that referenced
this pull request
Feb 18, 2025
Adjust to changes in TimelyDataflow/timely-dataflow#647 which removes flatcontainer and columnation as Timely doesn't have any opinion around the types and defers to downstream crates instead. Ideally, we'd move the TimelyStack to an example, but that would be a bigger change, so I'm holding off for the moment. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the dependencies on columnation and flatcontainer as far as
possible. This removes the TimelyStack type because it's not used in Timely
and only retains the columnation implementation for Product. Flatcontainer
was only used as an example, and we don't have any downstream dependencies
on it left.
Support for columnation and flatcontainer can be added by downstream crates
if they chose to do so.
Signed-off-by: Moritz Hoffmann antiguru@gmail.com