Use dep syntax with getopts#591
Merged
antiguru merged 2 commits intoTimelyDataflow:masterfrom Feb 28, 2025
Merged
Conversation
By using `dep:getopts`, there isn't a need to rename the package to `getopts_dep`.
Contributor
Author
|
This will conflict with #590, but I will happily rebase either this or that over top of whichever lands first. |
Member
|
Happy to merge, but also happy to let the rebase shake out. IIRC, the optional dependency only exists because some folks wanted to try and use DD as part of Rust's build chain, and you weren't allowed to depend on |
antiguru
force-pushed
the
use-dep-syntax-for-getopts
branch
from
58f3c90 to
7042ac6
Compare
Member
|
Thank you for the contribution! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using
dep:getopts, there isn't a need to rename the package togetopts_dep.