Rename internal Core variants#551
Merged
frankmcsherry merged 5 commits intoTimelyDataflow:masterfrom Mar 21, 2024
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have several "largely internal" types that are suffixed with
Corein an abundance of caution about breaking external uses. That caution is now gone, and we are going to start looking at changes that introduce the opinion that containers are the "right" least common denominator approach to using TD, andVeccontainers are mostly an ergonomic layer on top of them (and some amount of performance anti-pattern).There are other
Coretypes that are less internal, things likeStreamCore,HandleCore, and others. We'll eventually want to rationalize those as well, but they are likely to be very breaking rather than lightly breaking, and the migration there will probably look more like thetypestuff we have at the moment (though likely in somedataflow::vecmodule, rather than implicitly recommended for everyone).