Activate only by channel ID#526
Merged
frankmcsherry merged 3 commits intoTimelyDataflow:masterfrom Feb 5, 2024
Merged
Conversation
antiguru
commented
Jun 9, 2023
| use std::collections::VecDeque; | ||
|
|
||
| use crate::{Push, Pull}; | ||
| use crate::allocator::Event; |
Member
Author
There was a problem hiding this comment.
Check if Event still needs to exist.
timely/src/worker.rs
Outdated
| borrow.sort_unstable(); | ||
| borrow.dedup(); | ||
| for channel in borrow.drain(..) { | ||
| // TODO: Pay more attent to `_event`. |
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
force-pushed
the
activation_no_event
branch
from
2231deb to
34f287d
Compare
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
frankmcsherry
approved these changes
Feb 5, 2024
Member
frankmcsherry
left a comment
frankmcsherry
left a comment
There was a problem hiding this comment.
This makes sense to me, and we've left the comment in that reminds us how it might be different in the future (tracking the emptiness of channels, and not scheduling only on the basis of a message both sent and received).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes activation to avoid an associated event, which is currently not used anymore. It also switches to a
Vecto contain the activations, and deduplicates before activating operators.This improves performance in edge cases: