Validate timestamp summary before forming capability#497
Merged
frankmcsherry merged 2 commits intoTimelyDataflow:masterfrom Feb 10, 2023
Merged
Validate timestamp summary before forming capability#497frankmcsherry merged 2 commits intoTimelyDataflow:masterfrom
frankmcsherry merged 2 commits intoTimelyDataflow:masterfrom
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces to each
InputHandleCorethe antichain ofTimestamp::Summaryassociated with each output. Before the input will produce capabilities for the output, it first validates them against the summary to make sure that the requested timestamp complies with the operator's promise.This closes a hole in timely's "safety" story, and secretly opens another one that I will keep quiet for the moment.