Generalize flat container implementations to less specific regions #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure about this. It's a gross change as it pulls behavior across unrelated places, but I'm also not sure how to implement without effectively duplicating the `MergerChunk`. What might work is a trait that extends `MergerChunk` and just adds the `cmp_without_diff` function. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
commented
Jul 2, 2024
| @@ -280,27 +280,29 @@ where | |||
| } | |||
| } | |||
|
|
|||
| impl<K, V, T, R> ConsolidateLayout for FlatStack<TupleABCRegion<TupleABRegion<K, V>, T, R>> | |||
There was a problem hiding this comment.
This change is important.
antiguru
commented
Jul 2, 2024
| @@ -448,36 +448,30 @@ mod flatcontainer { | |||
| type OffsetContainer = OffsetList; | |||
| } | |||
|
|
|||
| impl<K,KBC,V,VBC,T,R> BuilderInput<KBC, VBC> for FlatStack<TupleABCRegion<TupleABRegion<K,V>,T,R>> | |||
There was a problem hiding this comment.
This change is important.
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
commented
Jul 8, 2024
| @@ -49,7 +49,7 @@ timely = {workspace = true} | |||
|
|
|||
| [workspace.dependencies] | |||
| #timely = { version = "0.12", default-features = false } | |||
| timely = { git = "https://github.com/TimelyDataflow/timely-dataflow", default-features = false } | |||
| timely = { git = "https://github.com/antiguru/timely-dataflow", branch = "flatcontainer_storage", default-features = false } | |||
There was a problem hiding this comment.
Wait for TimelyDataflow/timely-dataflow#574 to land.
5 tasks
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change redefines some trait implementations in differential for flat containers to be in terms of regions fulfilling some requirements instead of specific regions. The current implementation makes it impossible to implement the traits for specific regions due to Rust's orphan rules, which blocks us from using custom region implementations in Materialize.
The change should be localized to traits and implementations related to flat container. It includes some overdue renaming to make traits and generic parameters slightly more understandable.