Allow halfjoin to yield tastefully #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for the review! |
uce
reviewed
Oct 6, 2021
|
|
||
| let (mut cursor, storage) = trace.cursor(); | ||
| // Avoid computation if we should already yield. | ||
| // TODO: Verify this is correct for TOTAL ORDER. |
There was a problem hiding this comment.
@frankmcsherry Did you verify this?
There was a problem hiding this comment.
Not yet. This is an old comment though. I think it is green because the indentation level changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies some internals for
halfjointo allow it to yield by user-supplied logic. That logic can look at the elapsed time and number of matched records, where ideally if it uses neither of them there is not much overhead (the time is provided as anInstantwhich means that the user decides to callelapsedor not).cc @uce