Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Trace capability nomenclature #308

Merged
merged 3 commits into from
Feb 21, 2021
Merged

Conversation

frankmcsherry
Copy link
Member

@frankmcsherry frankmcsherry commented Feb 20, 2021

This PR changes TraceReader methods advance_by and distinguish_since, and their read counterparts, to more clearly named methods:

    fn set_logical_compaction(&mut self, frontier: AntichainRef<Self::Time>);
    fn get_logical_compaction(&mut self) -> AntichainRef<Self::Time>;
    fn set_physical_compaction(&mut self, frontier: AntichainRef<Self::Time>);
    fn get_physical_compaction(&mut self) -> AntichainRef<Self::Time>;

The documentation means to be a bit more clear about what these abilities entail.

@frankmcsherry
Copy link
Member Author

The prior method names are still present in #[deprecated] form, so ideally this doesn't break anything for anyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant