Skip to content

chore: Neighborhoods improvements for ListChangeMove#2076

Merged
triceo merged 4 commits intoTimefoldAI:mainfrom
triceo:moves
Feb 5, 2026
Merged

chore: Neighborhoods improvements for ListChangeMove#2076
triceo merged 4 commits intoTimefoldAI:mainfrom
triceo:moves

Conversation

@triceo
Copy link
Collaborator

@triceo triceo commented Feb 5, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the neighborhoods API for ListChangeMove by adding comprehensive test coverage, detailed Javadoc documentation, and a new shiftValue convenience method.

Changes:

  • Added extensive test coverage for ListChangeMove including same-entity moves, cross-entity moves, move properties, and rebase functionality
  • Added comprehensive Javadoc documentation for the Moves factory class and MutableSolutionView interface
  • Introduced shiftValue method as an alternative to moveValueInList using offset-based positioning
  • Improved validation with bounds checking for list indices in moveValueInList
  • Refactored ListChangeMove.execute() for better readability

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
ListChangeMoveTest.java Added comprehensive test coverage organized into nested test classes for same-entity moves, cross-entity moves, move properties, and rebasing
MoveDirectorTest.java Added tests for the new shiftValue method including edge cases and validation
Moves.java Added detailed Javadoc documentation for the factory class and all factory methods
ListChangeMove.java Minor refactoring of execute method for improved readability
MutableSolutionView.java Added new shiftValue method and convenience overloads using PositionInList, plus comprehensive documentation
MoveDirector.java Implemented shiftValue method, enhanced validation in moveValueInList, and refactored list operations

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I think the Javadoc for swap moves can be a bit clearer.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@triceo triceo merged commit 10b3157 into TimefoldAI:main Feb 5, 2026
35 of 36 checks passed
@triceo triceo deleted the moves branch February 5, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants