fix: Use field getters/setters when available, enforce getters/setters are public

[Christopher-Chianelli]

Before, this is how domain accessors were created:

• Annotation on the field? Make that field accessible and read/write directly to it.
• Annotation on a getter method? Make that method accessible, and pair it with the corresponding setter (if available) and read/write using the method pair.

Now, domain accessors are created like this:

• Annotation on the field? If the field has a getter, enforce that getter is public. If there is a setter but no getter, fail-fast. Use the field getter/setter for the MemberAccessor; only directly read/write the field if the field is public and there are no getters or setters for the field. Fail-fast otherwise.
• Annotation on a getter method? Enforce the getter is public, and pair it with the corresponding setter (if available, fail if there a setter and not public), and read/write using the method pair.

Quarkus generated MemberAccessors will also follow these same rules and use getters/setters if available.

This is a breaking change. Do not merge until 2.0 is branched.

Fixes #1862 and #1710.

[triceo]

I like this!

We need to figure out what to do with Gizmo. Personally, I'd just remove Gizmo from core, I don't see much point. It's not being used, and it complicates the codebase.

That said, I'm open to keeping Gizmo in core, if we can make it the default without changing any of the rules we just defined. In that case, it would only have benefits and therefore reflection-based access could be removed entirely.

Side note: there seem to be failing tests.

[Christopher-Chianelli]

Gizmo in core was modified to use getters/setters for fields if available.

[sonarqubecloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
74.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud