-
Notifications
You must be signed in to change notification settings - Fork 167
chore: refactor Neighborhoods package structure #1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
core/src/main/java/ai/timefold/solver/core/impl/heuristic/move/Move.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the Neighborhoods package structure by reorganizing classes from internal implementation packages (impl.neighborhood.maybeapi) to the public preview API (preview.api.neighborhood and preview.api.move.builtin). The refactoring also includes simplifying move adapters by removing legacy-to-new move conversion in favor of new-to-legacy conversion, and updating method names from extractPlanningEntities/Values() to getPlanningEntities/Values().
Key Changes
- Moved classes from
impl.neighborhood.maybeapitopreview.api.neighborhoodandpreview.api.move.builtin - Renamed methods:
extractPlanningEntities()→getPlanningEntities(),extractPlanningValues()→getPlanningValues() - Simplified move adapter logic by removing
LegacyMoveAdapterandLegacyIteratorAdapter
Reviewed changes
Copilot reviewed 141 out of 141 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Move.java (preview API) | Updated method names and improved error messages for tabu search methods |
| MoveAdapters.java | Simplified adapter logic to only convert new moves to legacy format |
| Various move definition files | Relocated from impl.neighborhood.maybeapi.move to preview.api.move.builtin |
| Various stream-related files | Relocated from impl.neighborhood.maybeapi.stream to preview.api.neighborhood.stream |
| Test files | Updated imports and method calls to reflect new package structure |
Comments suppressed due to low confidence (1)
core/src/main/java/ai/timefold/solver/core/preview/api/move/Move.java:1
- Error message incorrectly states 'getPlanningEntities()' when it should reference 'getPlanningValues()' for Value Tabu Search.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...olver/core/impl/heuristic/selector/move/generic/chained/SubChainReversingChangeMoveTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/heuristic/move/Move.java
Outdated
Show resolved
Hide resolved
...timefold/solver/core/impl/heuristic/selector/move/generic/chained/TailChainSwapMoveTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # core/src/main/java/ai/timefold/solver/core/impl/domain/variable/descriptor/ListVariableDescriptor.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 142 out of 142 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
core/src/main/java/ai/timefold/solver/core/preview/api/move/Move.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/neighborhood/stream/BiRandomMoveIterator.java
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/neighborhood/stream/BiOriginalMoveIterator.java
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/preview/api/move/builtin/SwapMove.java
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/preview/api/move/builtin/ListChangeMove.java
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/preview/api/move/builtin/ListAssignMove.java
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/preview/api/move/builtin/ListUnassignMove.java
Show resolved
Hide resolved
|


No description provided.