Skip to content

Conversation

@triceo
Copy link
Collaborator

@triceo triceo commented Dec 16, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Neighborhoods package structure by reorganizing classes from internal implementation packages (impl.neighborhood.maybeapi) to the public preview API (preview.api.neighborhood and preview.api.move.builtin). The refactoring also includes simplifying move adapters by removing legacy-to-new move conversion in favor of new-to-legacy conversion, and updating method names from extractPlanningEntities/Values() to getPlanningEntities/Values().

Key Changes

  • Moved classes from impl.neighborhood.maybeapi to preview.api.neighborhood and preview.api.move.builtin
  • Renamed methods: extractPlanningEntities()getPlanningEntities(), extractPlanningValues()getPlanningValues()
  • Simplified move adapter logic by removing LegacyMoveAdapter and LegacyIteratorAdapter

Reviewed changes

Copilot reviewed 141 out of 141 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Move.java (preview API) Updated method names and improved error messages for tabu search methods
MoveAdapters.java Simplified adapter logic to only convert new moves to legacy format
Various move definition files Relocated from impl.neighborhood.maybeapi.move to preview.api.move.builtin
Various stream-related files Relocated from impl.neighborhood.maybeapi.stream to preview.api.neighborhood.stream
Test files Updated imports and method calls to reflect new package structure
Comments suppressed due to low confidence (1)

core/src/main/java/ai/timefold/solver/core/preview/api/move/Move.java:1

  • Error message incorrectly states 'getPlanningEntities()' when it should reference 'getPlanningValues()' for Value Tabu Search.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# Conflicts:
#	core/src/main/java/ai/timefold/solver/core/impl/domain/variable/descriptor/ListVariableDescriptor.java
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 142 out of 142 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
64.4% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@triceo triceo merged commit 29fbc3b into TimefoldAI:main Dec 16, 2025
44 of 55 checks passed
@triceo triceo deleted the api branch December 16, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants