Skip to content

fix: do not share the node-shared classes #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
triceo merged 1 commit into from
Dec 15, 2025
+14 −3
Merged

fix: do not share the node-shared classes #1979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions core/src/main/java/ai/timefold/solver/core/enterprise/TimefoldSolverEnterpriseService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,13 @@ static <T> T loadOrDefault(Function<TimefoldSolverEnterpriseService, T> builder,

TopologicalOrderGraph buildTopologyGraph(int size);

Class<? extends ConstraintProvider>
buildLambdaSharedConstraintProvider(Class<? extends ConstraintProvider> originalConstraintProvider);
/**
* Will create new classes that apply node-sharing to the given {@link ConstraintProvider}.
* To reuse these classes, make sure to cache the returned {@link ConstraintProviderNodeSharer}.
*
* @return never null
*/
ConstraintProviderNodeSharer createNodeSharer();

<Solution_> ConstructionHeuristicDecider<Solution_> buildConstructionHeuristic(PhaseTermination<Solution_> termination,
ConstructionHeuristicForager<Solution_> forager, HeuristicConfigPolicy<Solution_> configPolicy);
Expand Down Expand Up @@ -161,6 +166,12 @@ public String getWorkaround() {

}

interface ConstraintProviderNodeSharer {

<T extends ConstraintProvider> Class<T> buildNodeSharedConstraintProvider(Class<T> constraintProviderClass);

}

final class EnterpriseLicenseException extends RuntimeException {

public EnterpriseLicenseException(String message) {
Expand Down
2 changes: 1 addition & 1 deletion ...old/solver/core/impl/score/director/stream/BavetConstraintStreamScoreDirectorFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ private static Class<? extends ConstraintProvider> getConstraintProviderClass(Sc
if (Boolean.TRUE.equals(config.getConstraintStreamAutomaticNodeSharing())) {
var enterpriseService =
TimefoldSolverEnterpriseService.loadOrFail(TimefoldSolverEnterpriseService.Feature.AUTOMATIC_NODE_SHARING);
return enterpriseService.buildLambdaSharedConstraintProvider(config.getConstraintProviderClass());
return enterpriseService.createNodeSharer().buildNodeSharedConstraintProvider(providedConstraintProviderClass);
} else {
return providedConstraintProviderClass;
}
Expand Down
Loading