Skip to content

Fix for amplitude_bell size offset#50

Merged
SebastianSchmidl merged 8 commits into
TimeEval:mainfrom
arrrrrmin:main
Mar 6, 2024
Merged

Fix for amplitude_bell size offset#50
SebastianSchmidl merged 8 commits into
TimeEval:mainfrom
arrrrrmin:main

Conversation

@arrrrrmin
Copy link
Copy Markdown

@arrrrrmin arrrrrmin commented Mar 5, 2024

As promised in #49 here is the fix for the amplitude_bell size offset (fixes #49).
I’m not very familiar with unittest TestCase-Classes, @CodeLionX could you please review the tests/test_generator/test_lengths.py?
There might be a more efficient way to check for the valid generation of anomalies under different length values?

Greetings and thanks for the very fast reply.

Copy link
Copy Markdown
Member

@SebastianSchmidl SebastianSchmidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the prompt fix (+ test cases). I like the test but have some suggestions for improvements.

👍🏼

Comment thread tests/test_generator/test_lengths.py Outdated
Comment thread tests/test_generator/test_lengths.py Outdated
Comment thread tests/test_generator/test_lengths.py Outdated
Comment thread tests/test_generator/test_lengths.py Outdated
Comment thread tests/test_generator/test_lengths.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (b2b18ca) to head (3697c3c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   89.99%   90.00%   +0.01%     
==========================================
  Files          53       53              
  Lines        2088     2091       +3     
==========================================
+ Hits         1879     1882       +3     
  Misses        209      209              
Flag Coverage Δ
unittests 90.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SebastianSchmidl SebastianSchmidl added 🐛 bug(-fix) Something isn't working / was fixed 🏅 high MoSCoW: Must-have comp: GutenTAG (general) labels Mar 5, 2024
@SebastianSchmidl
Copy link
Copy Markdown
Member

Mypy still fails on the test-file. You can add # type: ignore to the corresponding lines because specifying the full correct type of the config object is too verbose.

@SebastianSchmidl SebastianSchmidl merged commit d154e09 into TimeEval:main Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug(-fix) Something isn't working / was fixed comp: GutenTAG (general) 🏅 high MoSCoW: Must-have

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Amplitude anomaly fails with amplitude_bell size offset

2 participants