Use Chain
in traverseDirectly
helpers
#2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: Using
Chain
intraverseDirectly
helpers is better than usingVector
.The data
Below are comparison tables from JMH runs.
All runs were done with the following:
bench/jmh:run -i 10 -wi 10 -f 2 -t 1 cats.bench.TraverseBench
And with the jvmopts: -Xms2G -Xmx12G
The "worst diff" column is the worst case comparison, if the new result was at the bottom of it's error bound, and the old result was at the top.
The "within" column is basically the best case comparison, if this value is positive than we are within error bounds or better.
Comparing
this
(which usesChain
) to the latest from PR 4498 (which usesVector
):this
Compairing
this
to catsmain
:this
main