When disabling, set containerView alpha (and not button's alpha itself) - #16
Merged
Conversation
Owner
|
Hmm, I'd say either way is completely acceptable, although putting it in the container view is definitely a bit cleaner. Thanks for that! Maybe down the line, I'm wondering if there's a way to make the disabled effect opaque by just calculating which |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is actually a better implementation of #15 - It makes more sense to set the
containerView's alpha instead of the whole view's alpha.What do you think, @TimOliver ?