Conversation
Collaborator
Author
|
This is my first time actually using git worktrees properly i think, which is nice. I won't be directly committing to |
Collaborator
Author
|
Opinions on using |
faretek1
commented
Dec 19, 2025
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install . # install scratchattach from fs and dependencies |
Collaborator
Author
There was a problem hiding this comment.
i don't think uv sync will install the root project (scratchattach) itself. So possibly that needs to be added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue #548
Changes
Added dev dependencies (pytest and cryptography) to pyproject.toml. I also changed the
pytest.ymlworkflow to use uv (it got a bunch shorter which is nice)Tests
I tested the new workflow using workflow dispatch and the expected output is produced (after debugging)