Skip to content

Commit

Permalink
Add unit tests (apache#639)
Browse files Browse the repository at this point in the history
* Add tests for DefaultX509TrustManager

* Added tests for HadoopCmdOutput
  • Loading branch information
TheRealHaui authored and nichunen committed May 14, 2019
1 parent c39b238 commit 20fa8b1
Show file tree
Hide file tree
Showing 2 changed files with 102 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.kylin.engine.mr.common;

import org.junit.Test;

import java.security.KeyStoreException;
import java.security.NoSuchAlgorithmException;
import java.security.cert.X509Certificate;

import static org.junit.Assert.assertTrue;

/**
* Unit tests for class {@link DefaultX509TrustManager}.
*
* @see DefaultX509TrustManager
*
*/
public class DefaultX509TrustManagerTest{

@Test(expected = NullPointerException.class)
public void testIsServerTrustedThrowsNullPointerException() throws KeyStoreException, NoSuchAlgorithmException {
DefaultX509TrustManager defaultX509TrustManager = new DefaultX509TrustManager(null);

defaultX509TrustManager.isServerTrusted(new X509Certificate[1]);
}

@Test
public void testIsServerTrustedWithNull() throws KeyStoreException, NoSuchAlgorithmException {
DefaultX509TrustManager defaultX509TrustManager = new DefaultX509TrustManager(null);

assertTrue(defaultX509TrustManager.isServerTrusted(null));
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.kylin.engine.mr.common;

import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.mapreduce.Job;
import org.junit.Test;

import java.io.IOException;

import static org.junit.Assert.assertNull;

/**
* Unit tests for class {@link HadoopCmdOutput}.
*
* @see HadoopCmdOutput
*
*/
public class HadoopCmdOutputTest{

@Test(expected = IllegalStateException.class)
public void testGetMrJobIdThrowsIllegalStateException() throws IOException {
Job job = Job.getInstance(new Configuration(false));
HadoopCmdOutput hadoopCmdOutput = new HadoopCmdOutput(job, new StringBuilder());

assertNull(hadoopCmdOutput.getMrJobId());
}

@Test
public void testUpdateJobCounterCatchesEveryInternalException() throws IOException {
Job job = Job.getInstance(new Configuration(false));
HadoopCmdOutput hadoopCmdOutput = new HadoopCmdOutput(job, new StringBuilder());

hadoopCmdOutput.updateJobCounter();
}

}

0 comments on commit 20fa8b1

Please sign in to comment.