Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Floe Size Distribution (FSD) in Icepack (#281) #2

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

TillRasmussen
Copy link
Owner

  • adding fsd flags to icepack interface

  • fsd initialization, lateral melt fside

  • correct diagnostic, reduce number of fsd arrays

  • fsd lateral melt

  • fsd add_new_ice

  • wave_spec namelist

  • subroutine fsd_lateral_growth

  • move fsd routines to icepack_fsd.F90

  • add_new_ice using wave spectrum (0)

  • welding routine, some cleanup

  • call welding, debug

  • history except io_

  • initialize hi0new

  • initialization bug fixes, print statements

  • cleanup_fsd

  • Update sg_itd.rst

First draft adding FSTD definition

  • Update sg_thermo.rst

Add FSD lateral melt

  • reverting order of operations

  • Create sg_fsd.rst

Adding initial draft of FSD documentation

  • Think processes are ok except latg

  • Tested latg and newi

  • Update sg_thermo.rst

Added note on lateral growth

  • waves for fsd

  • Add new wave module

  • Testing waves

  • Working on waves, compiles but not yet tested

  • Update master_list.bib

Adding floe size distribution references

  • Update master_list.bib

  • Update sg_itd.rst

  • Update master_list.bib

  • Update sg_thermo.rst

  • Update master_list.bib

  • Update sg_thermo.rst

  • Update sg_itd.rst

  • Update sg_tracers.rst

  • Adding summary information, references etc

  • Delete sg_fsd.rst

  • Update icepack_wavefracspec.F90

  • Commenting icepack_fsd

  • Commenting icepack_therm_itd

  • Add dummy wave spectrum file

  • Delete ww3_wave_spectrum_runk_withcoords_remapgx3.nc

  • Calculate wave_sig_ht everywhere, not just in ice

  • Fixing wave fracture bug

  • Starting to add FSD to icepack driver. Not tested

  • Debugging - now compiles and runs

  • Modifying welding, adding check for wave fracture convergence

  • Checking wave fracture convergence

  • wrap fsd call with tr_fsd flag

  • initialize nfsd, nfreq; add -s fsd12 option

  • Add set_env,nml.fsd12 option files

  • Fixing typo in documentation

  • Working on classifier

  • Wave forcing and FSD initialization

  • Adding to documentation - waves and Icepack init

  • carriage return

  • debug restarts: set wave_spec, do not change ice_in, index nt_fsd+k-1 for writes and reads, add carriage return for set_env.fsd

  • add tr_fsd conditionals to initialization

  • abort if FSD, BGC both on; set default ice_ic

  • add FSD tests

  • declare tr_fsd

  • initialize tr_fsd

  • cleaning up

  • remove else from report_results.csh

  • Checked area conservation from wave fracture

  • refactor icepack_cleanup_fsd

  • use wave_spec_type in namelist instead of wave_spec

  • for consistency with CICE driver

  • Revert "Working on classifier"

This reverts commit 0c68947.

  • Tidying up

  • Tidying up notes in code

  • updae sg_thermo

add text about welding and the variable parameter (still identified as XX).

  • update wave fracture stuff

  • Edits to comments

  • Update ug_case_settings.rst

  • Update sg_itd.rst

  • Update sg_thermo.rst

  • update docs

  • bug fixes for wave_spec and divzero; comment out stops

  • update dfresh diagnostic calculation in icepack_therm_itd

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    ENTER INFORMATION HERE
  • Developer(s):
    ENTER INFORMATION HERE
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    ENTER INFORMATION HERE
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

* adding fsd flags to icepack interface

* fsd initialization, lateral melt fside

* correct diagnostic, reduce number of fsd arrays

* fsd lateral melt

* fsd add_new_ice

* wave_spec namelist

* subroutine fsd_lateral_growth

* move fsd routines to icepack_fsd.F90

* add_new_ice using wave spectrum (0)

* welding routine, some cleanup

* call welding, debug

* history except io_

* initialize hi0new

* initialization bug fixes, print statements

* cleanup_fsd

* Update sg_itd.rst

First draft adding FSTD definition

* Update sg_thermo.rst

Add FSD lateral melt

* reverting order of operations

* Create sg_fsd.rst

Adding initial draft of FSD documentation

* Think processes are ok except latg

* Tested latg and newi

* Update sg_thermo.rst

Added note on lateral growth

* waves for fsd

* Add new wave module

* Testing waves

* Working on waves, compiles but not yet tested

* Update master_list.bib

Adding floe size distribution references

* Update master_list.bib

* Update sg_itd.rst

* Update master_list.bib

* Update sg_thermo.rst

* Update master_list.bib

* Update sg_thermo.rst

* Update sg_itd.rst

* Update sg_tracers.rst

* Adding summary information, references etc

* Delete sg_fsd.rst

* Update icepack_wavefracspec.F90

* Commenting icepack_fsd

* Commenting icepack_therm_itd

* Add dummy wave spectrum file

* Delete ww3_wave_spectrum_runk_withcoords_remapgx3.nc

* Calculate wave_sig_ht everywhere, not just in ice

* Fixing wave fracture bug

* Starting to add FSD to icepack driver. Not tested

* Debugging - now compiles and runs

* Modifying welding, adding check for wave fracture convergence

* Checking wave fracture convergence

* wrap fsd call with tr_fsd flag

* initialize nfsd, nfreq; add -s fsd12 option

* Add set_env,nml.fsd12 option files

* Fixing typo in documentation

* Working on classifier

* Wave forcing and FSD initialization

* Adding to documentation - waves and Icepack init

* carriage return

* debug restarts: set wave_spec, do not change ice_in, index nt_fsd+k-1 for writes and reads, add carriage return for set_env.fsd

* add tr_fsd conditionals to initialization

* abort if FSD, BGC both on; set default ice_ic

* add FSD tests

* declare tr_fsd

* initialize tr_fsd

* cleaning up

* remove else from report_results.csh

* Checked area conservation from wave fracture

* refactor icepack_cleanup_fsd

* use wave_spec_type in namelist instead of wave_spec

* for consistency with CICE driver

* Revert "Working on classifier"

This reverts commit 0c68947.

* Tidying up

* Tidying up notes in code

* updae sg_thermo

add text about welding and the variable parameter (still identified as XX).

* update wave fracture stuff

* Edits to comments

* Update ug_case_settings.rst

* Update sg_itd.rst

* Update sg_thermo.rst

* update docs

* bug fixes for wave_spec and divzero; comment out stops

* update dfresh diagnostic calculation in icepack_therm_itd
@TillRasmussen TillRasmussen merged commit ff8784d into TillRasmussen:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants