Removed too restrictive error on rendering external links. Now, external links can target the same domain as the current page

brigid/markdown_render/processors/external_links.py

@@ -3,7 +3,6 @@
 from markdown.inlinepatterns import LINK_RE as EXTERNAL_LINK_RE
 from markdown.inlinepatterns import LinkInlineProcessor
 
-from brigid.library.storage import storage
 from brigid.markdown_render.context import render_context
 
 
@@ -23,22 +22,10 @@ def handleMatch(self, m, data):  # noqa # pylint: disable=all
 
         parsed_url = urlparse(href)
 
-        site = storage.get_site()
-
         context = render_context.get()
 
-        parsed_site = urlparse(site.url)
-
         # validate external links
 
-        # TODO: compare taking into account the default ports, aka example.com:90 = example.com
-        # TODO: is this required, link could be to the same domain but in different project
-        if parsed_site.netloc == parsed_url.netloc:
-            context.add_error(
-                failed_text=data, message="Use internal links syntax to specify links to the same domain"
-            )
-            return result
-
         if parsed_url.scheme == "":
             context.add_error(failed_text=data, message="Specify schema/protocol for external links")
             return result

brigid/markdown_render/processors/tests/test_external_links.py

@@ -1,4 +1,3 @@
-from brigid.library.storage import storage
 from brigid.library.tests import make as library_make
 from brigid.markdown_render.markdown_render import render_page
 
@@ -34,19 +33,3 @@ def test_no_schema(self) -> None:
 
         assert len(result.errors) == 1
         assert result.errors[0].message == "Specify schema/protocol for external links"
-
-    def test_used_for_internal_links(self) -> None:
-
-        site = storage.get_site()
-
-        text = f"""
-[xxx]({site.url})
-        """
-
-        article = library_make.article()
-        page = library_make.page(article, body=text)
-
-        result = render_page(page)
-
-        assert len(result.errors) == 1
-        assert result.errors[0].message == "Use internal links syntax to specify links to the same domain"

changes/next_release.md

@@ -0,0 +1,2 @@
+
+- Removed too restrictive error on rendering external links. Now, external links can target the same domain as the current page.