Refactors and extends utils.collectDOMProperties #9601
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2447.9 KB |
| PR | 2448.1 KB |
Diff: ⬆️ Increase: +0.2 KB
⚠️ Change Note Status
This PR appears to contain code changes but doesn't include a change note.
Please add a change note by creating a .tid file in editions/tw5.com/tiddlers/releasenotes/<version>/
📚 Documentation: Release Notes and Changes
💡 Note: If this is a documentation-only change, you can ignore this message.
|
Confirmed: saqimtiaz has already signed the Contributor License Agreement (see contributing.md) |
saqimtiaz
changed the title
pmario
reviewed
Jan 26, 2026
core/modules/utils/dom/dom.js
Outdated
| }); | ||
| }; | ||
|
|
||
| const getBoundingRect = (node) => { |
Member
There was a problem hiding this comment.
@Jermolene @saqimtiaz ... I would like, if this code formatting for arrow functions would be the default. See draft PR at: #9590
So the error message below will be gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors $tw.utils.collectDOMProperties:
Requires: #9609
Question:
should we provide individual variables for the properties of the boundingClientRect, as this PR currently does, such as
tv-selectednode-client-width,tv-selectednode-client-height,tv-selectednode-client-leftandtv-selectednode-client.top, OR one variable as a JSON blob:tv-selectednode-clientRect