Make HTTP Basic Auth aware of path-prefix #8789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed: jrbntt has already signed the Contributor License Agreement (see contributing.md) |
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks @jrbntt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in #8788, if a user combines a
path-prefixandreaders=(anon)for the Node.js server, manual HTTP Basic Authentication via "/login-basic" will redirect the authenticated user to the server root "/" instead of the correct URI including the path prefix.This PR makes a small change to prefix the default redirection URL with the value of the path prefix.
It appears that the server boot process will set state.pathPrefix to "" if it is not configured, so it should be safe to simply reference the value in a string template without an additional conditional check at the moment of use. I have tested this change both with and without the
path-prefixserver parameter and was correctly redirected after authentication in both configurations.Closes #8788