Skip to content

Conversation

@stopfstedt
Copy link
Collaborator

@stopfstedt stopfstedt commented Jul 31, 2020

  • update to latest supported console component dependency.
  • use dependency injection over container awareness.
  • future-proof execute() methods with return values.

refs #414

dependabot-preview bot and others added 3 commits July 31, 2020 04:38
Bumps [symfony/console](https://github.com/symfony/console) from 3.4.42 to 4.4.11.
- [Release notes](https://github.com/symfony/console/releases)
- [Changelog](https://github.com/symfony/console/blob/master/CHANGELOG.md)
- [Commits](symfony/console@v3.4.42...v4.4.11)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
ensure forward-compat by adding return value to execute methods.
remove container awareness and use DI instead where possible.
@stopfstedt stopfstedt merged commit f7ed639 into ThronesDB:master Jul 31, 2020
@stopfstedt stopfstedt deleted the modernize_commands branch July 31, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant