Add ConfigAwarePlaceholders class#997
Merged
thiagoloureiro merged 2 commits intoThreeMammals:developfrom Sep 12, 2019
Merged
Conversation
This allows placeholder values to be sourced from IConfiguration in addition to set values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows placeholder values to be sourced from IConfiguration in
addition to set values.
New Feature
Proposed Changes
I found myself writing a few
DelegatingHandlersfor appending headers for downstream calls using values fromIConfiguration. This PR contains a new implementation ofIPlaceholders.This decorates and replaces the
IPlaceholdersinstaces in the IoC container to allow the existing placeholders to be used (it checks these first). The idea is to have config like:I've added
AddConfigPlaceholders()toIOcelotBuilderbut I wasn't sure if that was the correct location, or if somewhere else would work.