Use final paths in the reroutes of configuration.json file.#89
Merged
TomPallister merged 2 commits intoThreeMammals:masterfrom Apr 23, 2017
Merged
Conversation
…on.json file. Adds a unit test method to test the functionality.
Member
|
@juancash Looks good thanks for the effort! Could you write an acceptance test for this so we know it works end to end? If you just add it to the RoutingTests.cs file. This shouldn't be too much work as you can just use the methods already in there! Basically copy a test and change it! |
Closed
Contributor
Author
|
@tom Acceptance test added. |
Member
|
@juancash thank you very much! I will merge this now. |
raman-m
added a commit
to ggnaegi/Ocelot
that referenced
this pull request
Nov 15, 2024
ggnaegi
added a commit
that referenced
this pull request
Nov 17, 2024
* Adding support for placeholder matching between slashes.
* now the behavior is right, it can't be that {finalUrlPath} matches product/products/categories/ since the last slash is part of the template and not the catch-all placeholder
* Performance improvements for EscapeExceptBraces
* EOL: test/Ocelot.UnitTests/DownstreamRouteFinder/UrlMatcher/UrlPathPlaceholderNameAndValueFinderTests.cs
Recover old test for feat 89.
Remove BDDfy from new unit tests.
Apply AAA-pattern.
* Review user scenarios of feat #89 tests
* Refactor unit tests
* Refactor acceptance tests
* Adding documentation for embedded placeholders
* Adding acceptance tests
* Adding suggestions
* again...
* Final code review by @raman-m.
FindGroups method is private, better to return exact type.
Regex optimizations across net6, 7, 8.
XML dev-docs markup review.
Rename 'curly bracket' to 'brace'.
---------
Co-authored-by: Raman Maksimchuk <dotnet044@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is the user not have to map all request when use Ocelot like a simple request redirector.
Imagine the following scenario:
The configuration.json for internal gateway could be something like this:
If we add new controllers to our web apis, we don´t need edit the internal gateway configuration, because the traffic will be redirected without problems.
Thanks.