Fix/issue666

[aliprogrammer69]

fixed issue
#666

[thiagoloureiro]

@aliprogrammer69 Hi mate, your PR looks good, Just wondering if we need to unit test this method:

GenerateRequestCacheKey

[aliprogrammer69]

dear @thiagoloureiro I wrote unit test to cover method GenerateRequestCacheKey and sent pull request AppVeyor build succeeded but the travis ci returned error below

The command "sudo apt-get install -qq dotnet-sdk-2.1=2.1.500*" failed and exited with 100 during .

[thiagoloureiro]

dear @thiagoloureiro I wrote unit test to cover method GenerateRequestCacheKey and sent pull request AppVeyor build succeeded but the travis ci returned error below

The command "sudo apt-get install -qq dotnet-sdk-2.1=2.1.500*" failed and exited with 100 during .

Sometimes travis-ci causes issues, appveyor was ok, so no worries.

[aliprogrammer69]

is there any problem? when are you going to release new version and publish to nuget?

[alashti]

this bug costs a lot for us.
thanks for your work on its fixing.
when does it going to be released? is it possible to use it in following days?

[thiagoloureiro]

will release today later the new version ok ! :)

[raman-m]

@aliprogrammer69 Your design is not well-developed!

It seems your PR was not carefully reviewed in 2019 or not reviewed at all, right?

[raman-m]

@thiagoloureiro You managed Ocelot project in 2019...
After closing and merging this PR the original feature #666 was not closed. Why?
Why didn't you close the feature?
Ok, I'm going to close the issue to help you...

And congrats! As a team lead of this project in 2019 after your merging you've introduced new source of out-of-memory problem and/or just a memory leakage potential problem. At least this design implementation consumes high memory & CPU too. The CacheKeyGenerator class implementation is totally wrong in these lines:

if (downstreamRequest.Content != null)
{
    var requestContentString = Task.Run(async () => await downstreamRequest.Content.ReadAsStringAsync()).Result;
    downStreamUrlKeyBuilder.Append(requestContentString);
}

Congrats, Thiago! 💥