#2064 2065 #2132 #2169 Ampersand vs Slash workaround in UpstreamTemplatePatternCreator

[int0x81]

Fixes #2132 #2169

• Incorrect Routing when a configuration exists with query param wildcard #2132
• Bug with catch-all routing #2169

Closes #2064 #2065

• Incorrect routing when the query parameter is in the configuration #2064
• Incorrect routing when the query parameter is in the configuration #2065

[raman-m]

Thanks for the PR creation!
Why don't you request code reviews?

[raman-m]

Our development process mandates the inclusion of acceptance tests for even the smallest fixes. Please refer to points 4 and 5.

• Development Process | RST docs

So, please add acceptance tests!

[raman-m]

$\color{red}{No\ acceptance\ tests!}$

Please include tests. If you're uncertain about where to locate the appropriate testing class within the Ocelot.AcceptanceTests project, please inform me.

Please add tests to Routing → RoutingTests

[raman-m]

@ggnaegi Please join to review the Finn's coding art 😋

[int0x81]

N o a c c e p t a n c e t e s t s !

Please include tests. If you're uncertain about where to locate the appropriate testing class within the Ocelot.AcceptanceTests project, please inform me.

Please add tests to Routing → RoutingTests

@raman-m
I added an acceptance test based on the issue #2065

[ggnaegi]

Hello, thanks a lot, it would be imho, more elegant to use a ternary operator, or even Regex.Replace

[raman-m]

Reviewing and checking tests...

[raman-m]

A few issues should be resolved!

[raman-m]

@int0x81 Could you clarify this for me? 👇

Why have you restricted my ability to push to your forked repository?
I am not able to assist you with pair programming...

[raman-m]

@int0x81 Dear Finn,
Could you please respond to my question? I would like to push a small code review commit.

As per GitHub's policy on forking repositories, maintainers or owners of the base repository have write permission to the feature branches of the pull requests, but not to other branches, including protected ones.
Could you clarify what actions were taken with your forked repository that resulted in me not having push access?

@ggnaegi FYI

[int0x81]

@raman-m I usually disable the option Allow edit by maintainers, because I like to have control over my changes and avoid confusion. Please don't take it personally :D. However, I just enabled it so you can push changes, but please keep your changes small so I can follow up on them.

[raman-m]

Ready for Delivery ✅

[raman-m]

Hello Finn,
I've prioritized this PR for the upcoming .NET 9 release, so it's now ready for merging.
If you're okay with the minor enhancements in b7853e0, feel free to press the magic Squash and merge button 😉
Please avoid using the Create a merge commit option❗

[int0x81]

Hello Finn, I've prioritized this PR for the upcoming .NET 9 release, so it's now ready for merging. If you're okay with the minor enhancements in b7853e0, feel free to press the magic Squash and merge button 😉 Please avoid using the Create a merge commit option❗

@raman-m

I don't think I am authorized to merge. The button is disabled for me. But I reviewed the changes and it looks good to me, so you can also perform the merge directly

[raman-m]

I don't think I am authorized to merge. The button is disabled for me.

Yes, right! Only team members can merge to protected branches. Done! Merged!
Thank you for your contribution!