Skip to content

Comments

#2145 Refactor Infrastructure StringExtensions#2222

Merged
raman-m merged 1 commit intodevelopfrom
raman-m/2145
Nov 28, 2024
Merged

#2145 Refactor Infrastructure StringExtensions#2222
raman-m merged 1 commit intodevelopfrom
raman-m/2145

Conversation

@raman-m
Copy link
Member

@raman-m raman-m commented Nov 27, 2024

Fixes #2145

Proposed Changes

  • Refactored StringExtensions: added developer's XML docs
  • Renamed TrimStart method to TrimPrefix because of .NET Runtime TrimStart.
  • Updated unit tests

@raman-m raman-m self-assigned this Nov 27, 2024
@raman-m raman-m requested review from RaynaldM and ggnaegi November 27, 2024 10:35
@raman-m raman-m added bug Identified as a potential bug proposal Proposal for a new functionality in Ocelot Core Ocelot Core related or system upgrade (not a public feature) labels Nov 27, 2024
@raman-m raman-m added this to the .NET 9 milestone Nov 27, 2024
@raman-m raman-m changed the title Refactor StringExtensions #2145 Refactor Infrastructure StringExtensions Nov 27, 2024
@raman-m raman-m added the NET9 .NET 9 release label Nov 27, 2024
Copy link
Collaborator

@ggnaegi ggnaegi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fine, ready for .NET 9 upgrade

@raman-m raman-m merged commit 2e352bc into develop Nov 28, 2024
@raman-m raman-m deleted the raman-m/2145 branch November 28, 2024 07:41
@raman-m
Copy link
Member Author

raman-m commented Nov 28, 2024

@ggnaegi left a comment
Ok, fine, ready for .NET 9 upgrade

Are you? 😋
What task in .NET 9 milestone do you want to assign yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Identified as a potential bug Core Ocelot Core related or system upgrade (not a public feature) NET9 .NET 9 release proposal Proposal for a new functionality in Ocelot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET 9 update will break one of the tests because of a new TrimStart overload

2 participants