[#1527 #1529] Breaking change to the class renaming of Kube service discovery provider

[ZisisTsatsas]

The Type field for the Kubernetes example is outdated in the docs

---

Update by Maintainer on Feb 10, 2024 👉

Fixes #1527 #1529

• Errors when running Ocelot.Provider.Kubernetes in Azure K8 #1527
• UnableToFindServiceDiscoveryProviderError for type "consul " when using type "kube" #1529

[raman-m]

@ZisisTsatsas Hi Zisis!
Thanks for the issue reporting!

You are right, the docs were not updated.
But it was my mistake when I renamed the class a half of the year ago... Seems we need to rename the class back to Kube.
So, finally there should be old two types: Kube and PollKube... and docs can be unchanged.
Sorry, for this breaking change!

@ggnaegi Do you agree using old types Kube and PollKube? But I know you don't use these providers...

[raman-m]

@ZisisTsatsas Could you help me with resolving this breaking change plz?
Or, I will work on the issue this weekend... Sorry, I'm very busy today and will be offline right away.

[raman-m]

The root cause of the problem:

Ocelot/src/Ocelot/ServiceDiscovery/ServiceDiscoveryProviderFactory.cs

Line 59 in c9510b1

if (provider.GetType().Name.ToLower() == config.Type.ToLower())

of these block of code:

Ocelot/src/Ocelot/ServiceDiscovery/ServiceDiscoveryProviderFactory.cs

Lines 55 to 63 in c9510b1

	if (_delegates != null)
	{
	var provider = _delegates?.Invoke(_provider, config, route);
	if (provider.GetType().Name.ToLower() == config.Type.ToLower())
	{
	return new OkResponse<IServiceDiscoveryProvider>(provider);
	}
	}

where _delegates is ServiceDiscoveryFinderDelegate and it is added into the DI:

Ocelot/src/Ocelot.Provider.Kubernetes/OcelotBuilderExtensions.cs

Line 11 in c9510b1

.AddSingleton(KubernetesProviderFactory.Get)

Finally, in this line of code we have

Ocelot/src/Ocelot/ServiceDiscovery/ServiceDiscoveryProviderFactory.cs

Line 59 in c9510b1

if (provider.GetType().Name.ToLower() == config.Type.ToLower())

→ if ("KubernetesServiceDiscoveryProvider".ToLower() == "Kube".ToLower()) which is false always!
This is the bug and the breaking change ❗

[raman-m]

Hi @ZisisTsatsas !
I found a couple of issues related to Kube provider and attached them to your PR 👉

• Errors when running Ocelot.Provider.Kubernetes in Azure K8 #1527
• UnableToFindServiceDiscoveryProviderError for type "consul " when using type "kube" #1529

So, these bugs will be closed officially by your PR 😉

@ggnaegi FYI

[raman-m]

Development completed ✔️

@RaynaldM @ggnaegi Please review!

[raman-m]

Approved by @ggnaegi

The build is 🟢

Ready for delivery! ✔️

[raman-m]

Funny fact is that the breaking change was introduced in 15.0.0 release by Tom in the commit 6e5471a 🤯
I thought that I was the author of the bug in 19.x or 20.0 releases 🤣 but No: Tom did the thing. 😄

[raman-m]

@ZisisTsatsas
Will you use our updated & fixed Kubernetes provider and Ocelot after the release? 😉

[ZisisTsatsas]

@ZisisTsatsas Will you use our updated & fixed Kubernetes provider and Ocelot after the release? 😉

I will be using it! Thanks for the quick udpate