Merged
Conversation
* fix #1833, Default timeout(90s) of downstream requests is broken * Fix test Should_log_warning_if_downstream_service_returns_internal_server_error * Add unit tests * Recover mixed line endings. Add docs * Unit tests for HttpClientBuilder * Add issue info * Acceptance test * Just formatting --------- Co-authored-by: alvin huang <alvin.huang@grapecity.com> Co-authored-by: Raman Maksimchuk <dotnet044@gmail.com>
raman-m
added
release
RaynaldM
approved these changes
Dec 8, 2023
| { | ||
| DurationOfBreak = 1; | ||
| ExceptionsAllowedBeforeBreaking = 0; | ||
| TimeoutValue = int.MaxValue; |
Contributor
There was a problem hiding this comment.
For me, we have to indicate that it's a Breaking Change, for example, we have this kind of code in our sources:
if (route.QosOptions.TimeoutValue != int.MaxValue)
{
pipeline.AddTimeout(TimeSpan.FromMilliseconds(route.QosOptions.TimeoutValue));
}
and that others may have done the same.
Member
Author
There was a problem hiding this comment.
OK I will edit Release Notes when released and add Breaking Change note to Tech Info...
This was referenced Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features