#649 Acceptance tests#1846
Merged
raman-m merged 3 commits intoThreeMammals:developfrom Dec 8, 2023
ks1990cn:issue649
Merged
Conversation
ks1990cn
commented
Dec 7, 2023
| [Theory] | ||
| [InlineData("/products")] | ||
| [InlineData("/products/")] | ||
| [Trait("Issue","Should fix issue 649")] |
Contributor
Author
There was a problem hiding this comment.
@raman-m Here I am using Trait attribute here with Issue key.
Trait have key,value feature which provides easy way to filter out issue category verification test cases.
I am not writing another test case with method name "should_fix_issue_649", cause it will be eventually same by execution.
We can categorize with Issue key when we do verification from checkbox filter in test explorer.
Member
There was a problem hiding this comment.
[Trait] is a nice feature of xUnit! Make sense to use...
Member
There was a problem hiding this comment.
Officially it is better to have separate tests for the issue to close it finally
Member
|
Reviewing... |
raman-m
changed the title
Member
|
Congrats, Tanmay! 🥳 This is your first merged PR! 🎉 |
This was referenced Feb 11, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #649
Modifying acceptance test case as per issue.
Proposed Changes