One less warning with async

[AnthonySteele]

Fixes / New Feature #

Proposed Changes

Remove a warning about the use of async without await:

Warning	CS1998	
This async method lacks 'await' operators and will run synchronously. 
Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.	
Ocelot.AcceptanceTests	C:\code\Ocelot\test\Ocelot.AcceptanceTests\ResponseCodeTests.cs	59	

[AnthonySteele]

I can look at more warnings to get familiar with the code, but I thought it best to start small.

Eventually you get to no warnings, so any regression to that stands out.

Some of them should probably be suppressed, e.g. IDE1006 ( naming ) in the tests and SA1413 ( trailing commas ) throughout.

[raman-m]

Anthony,
A lot of warning and compiler messages were fixed by my PR #1663 .

After merging develop branch with conflicts resolution, I took changes from develop branch because async was removed. We create PRs to develop now.
And now I don't see changes in diff at all.
Do you see? 😄

I believe this warning is gone now.
Could you confirm that please?

[raman-m]

LoL 🤣
You've closed the PR!

Was it confirmation?

[AnthonySteele]

Yeah, it doesn't seem relevant any more (3 years ago?)

If we want to do this, it would be easier to start again. I don't have context after that time.