Skip to content

Comments

#651 Merge custom JSON properties across multiple ocelot.X.json configuration files using Newtonsoft's JToken merge functionality#1183

Open
jlukawska wants to merge 19 commits intoThreeMammals:developfrom
jlukawska:feature/651-merge-custom-properties
Open

#651 Merge custom JSON properties across multiple ocelot.X.json configuration files using Newtonsoft's JToken merge functionality#1183
jlukawska wants to merge 19 commits intoThreeMammals:developfrom
jlukawska:feature/651-merge-custom-properties

Conversation

@jlukawska
Copy link
Contributor

@jlukawska jlukawska commented Apr 7, 2020 •
edited by raman-m
Loading

Closes #651

Proposed Changes

  • The whole sections of config files (with custom properties) are merged.

@raman-m raman-m changed the title Feature/651 merge custom properties of config file #651 Merge custom properties of config file Jul 20, 2023
@raman-m raman-m changed the base branch from master to develop July 20, 2023 15:24
@raman-m raman-m self-requested a review July 20, 2023 16:05
@raman-m raman-m added the feature A new feature label Jul 20, 2023
@raman-m raman-m force-pushed the feature/651-merge-custom-properties branch from 4eb4482 to 9ec4b8d Compare July 26, 2023 14:36
@raman-m
Copy link
Member

raman-m commented Jul 26, 2023

Congrats, @jlukawska ! 🎉
Your feature branch has been rebased onto ThreeMammals:develop.

We can go with code review now...

@raman-m raman-m mentioned this pull request Jul 26, 2023
Open
@raman-m raman-m added the needs feedback Issue is waiting on feedback before acceptance label Jul 26, 2023
@raman-m raman-m mentioned this pull request Aug 1, 2023
Closed
@raman-m
Copy link
Member

raman-m commented Aug 3, 2023

@nurhat
As the #651 issue author, could you review this solution please?
Will the solution be useful and helpful for your daily gateway development?

@raman-m
Copy link
Member

raman-m commented Aug 3, 2023 •
edited
Loading

@RaynaldM @wast
You are great approvers! 🥇
Seems like @jlukawska is making breaking changes and you've approved them. 🤣
I am not sure about changes that they're breaking on 100%, but I will review the code thoroughly. 👇

raman-m
raman-m requested changes Aug 3, 2023
View reviewed changes
Copy link
Member

@raman-m raman-m left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlukawska
Could you fix the issues please?

How to read CustomStrategyProperty value of the route in run-time?

src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs Outdated

fileConfiguration.Aggregates.AddRange(config.Aggregates);
fileConfiguration.Routes.AddRange(config.Routes);
MergeConfig(fileConfiguration, config, isGlobal);
Copy link
Member

@raman-m raman-m Aug 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 Merged config JSON goes to primaryConfigFile. And it will be serialized to ocelot.json file.
And the primary config will be attached to IConfigurationBuilder object by AddJsonFile method.

Could you show me a case how can I read this custom property inside of extension-methods for IConfigurationBuilder interface?

@raman-m
Copy link
Member

raman-m commented Aug 3, 2023 •
edited
Loading

@nurhat @jlukawska
I would like to understand, how useful this feature for real world user scenarios.

User case 1

Change behavior of PollyQoSProvider

Given, I wish to override behavior of the Quality of Service feature by changes in PollyQoSProvider and/or AddPolly and/or PollyCircuitBreakingDelegatingHandler classes.
And, I will define custom property of the route for custom QoS overriding in a ocelot.xservices.json file.
And, I will read the custom property from DownstreamRoute object after merging all configs.
When, I read the custom property from DownstreamRoute object.
Then, I get stuck! 😉

Question:

  • How to read custom property from DownstreamRoute object?
  • How and what interface do I need to inject to a service class to be able to read custom property from DownstreamRoute object?

@raman-m raman-m mentioned this pull request Aug 18, 2023
Closed
@raman-m raman-m force-pushed the feature/651-merge-custom-properties branch from 04debe6 to 7f61d01 Compare October 12, 2023 12:16
@raman-m raman-m force-pushed the develop branch 20 times, most recently from 908d84f to 0678e7a Compare April 19, 2025 15:13
@raman-m raman-m added the Winter'26 Winter 2026 release label May 27, 2025
@raman-m raman-m added this to the Summer'25 milestone May 27, 2025
@raman-m raman-m added the conflicts Feature branch has merge conflicts label Jan 9, 2026
@raman-m raman-m removed the conflicts Feature branch has merge conflicts label Jan 10, 2026
@coveralls
Copy link
Collaborator

coveralls commented Jan 12, 2026

Coverage Status

coverage: 93.397% (-0.1%) from 93.503%
when pulling 94e251d on jlukawska:feature/651-merge-custom-properties
into 9fc4e78 on ThreeMammals:develop.

@raman-m
Copy link
Member

raman-m commented Jan 12, 2026

Ready for code review ✔️

  • Require code coverage improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raman-m raman-m Awaiting requested review from raman-m

@ggnaegi ggnaegi Awaiting requested review from ggnaegi

2 more reviewers

@RaynaldM RaynaldM RaynaldM approved these changes

@wast wast wast approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

@jlukawska jlukawska

Labels

Configuration Ocelot feature: Configuration feature A new feature Winter'26 Winter 2026 release

Projects

None yet

Milestone

Winter'26

Development

Successfully merging this pull request may close these issues.

Extending Route configuration

5 participants

@jlukawska @raman-m @coveralls @RaynaldM @wast