Skip to content

Conversation

@hlubek
Copy link
Contributor

@hlubek hlubek commented Jul 19, 2023

This fixes the original issue by checking consumer info first but still has a chance of a race condition (in theory). I also added a test which can reproduce the issue with lost messages without that fix.

Having an additional loop to handle consumer deletion would need some more changes though, so I went for the easier solution for now.

Fixes #24

@minghsu0107
Copy link
Collaborator

@hlubek Great job! I've made some minor improvements to your code and also included configuration options for the subscriber. Take a look at the changes I've made in this branch: https://github.com/ThreeDotsLabs/watermill-redisstream/tree/pr-24

Please feel free to reference my code and integrate it with yours. We can then update the new version in this PR.

@hlubek
Copy link
Contributor Author

hlubek commented Jul 20, 2023

@minghsu0107 Thanks! I just integrated your changes.

@minghsu0107
Copy link
Collaborator

LGTM

@minghsu0107 minghsu0107 merged commit f70320f into ThreeDotsLabs:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Claim fails for consumers with multiple pending messages

2 participants