Skip to content

Commit

Permalink
Simplify code (gin-gonic#2004)
Browse files Browse the repository at this point in the history
- Use buf.String instead of converison
- Remove redundant return
  • Loading branch information
muesli authored and ThomasObenaus committed Feb 19, 2020
1 parent ecddd03 commit 47095cf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion gin.go
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,6 @@ func serveError(c *Context, code int, defaultMessage []byte) {
return
}
c.writermem.WriteHeaderNow()
return
}

func redirectTrailingSlash(c *Context) {
Expand Down
2 changes: 1 addition & 1 deletion render/render_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func TestRenderMsgPack(t *testing.T) {
err = codec.NewEncoder(buf, h).Encode(data)

assert.NoError(t, err)
assert.Equal(t, w.Body.String(), string(buf.Bytes()))
assert.Equal(t, w.Body.String(), buf.String())
assert.Equal(t, "application/msgpack; charset=utf-8", w.Header().Get("Content-Type"))
}

Expand Down

0 comments on commit 47095cf

Please sign in to comment.