Skip to content

Commit

Permalink
keep the ordering of characters/classes
Browse files Browse the repository at this point in the history
The changes from pull request gap-system#3253 had the effect that the orderings
of characters and classes in the result of `CharacterTableIsoclinic`
were different from those in released versions of GAP.

With the current change, we return to the previous orderings.
  • Loading branch information
ThomasBreuer committed Jul 17, 2019
1 parent b5373a3 commit 96d7671
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions lib/ctbl.gi
Original file line number Diff line number Diff line change
Expand Up @@ -5997,7 +5997,7 @@ InstallOtherMethod( CharacterTableIsoclinic,
"for an ordinary character table and two lists of class positions",
[ IsOrdinaryTable, IsObject, IsObject ],
function( tbl, nsg, center )
local size, classes, r;
local size, classes, orders, max, r;

size:= Size( tbl );
classes:= SizesConjugacyClasses( tbl );
Expand All @@ -6011,9 +6011,9 @@ InstallOtherMethod( CharacterTableIsoclinic,

if IsList( center ) then
# find an element of largest order
center:= ShallowCopy( center );
SortParallel( OrdersClassRepresentatives( tbl ){ center }, center );
center:= center[ Length( center ) ];
orders:= OrdersClassRepresentatives( tbl );
max:= Maximum( orders{ center } );
center:= First( center, i -> orders[i] = max );
fi;

r:= rec();
Expand Down Expand Up @@ -6354,9 +6354,12 @@ InstallMethod( CharacterTableIsoclinic,
irreducibles:= List( Irr( modtbl ), ValuesOfClassFunction );
else
factorfusion:= GetFusionMap( reg, ordiso );
xpos:= source.centralElement;
xpos:= Position( factorfusion, source.centralElement );
centre:= [ xpos ];
outer:= source.outerClasses;
outer:= List( source.outerClasses,
l -> Filtered( List( l,
i -> Position( factorfusion, i ) ),
IsInt ) );
irreducibles:= IrreducibleCharactersOfIsoclinicGroup( Irr( modtbl ),
centre, outer, xpos, source.p, source.k ).all;
fi;
Expand Down

0 comments on commit 96d7671

Please sign in to comment.