Add convenience code which allows writing G.:1 resp. G."1"

... in Julia, to access the value of `G.1` on the GAP side.
ThomasBreuer · Feb 20, 2019 · 61841c5 · 61841c5
1 parent 14ec79a
commit 61841c5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/LibGAP.jl/src/gap.jl b/LibGAP.jl/src/gap.jl
@@ -31,9 +31,14 @@ Base.getindex(x::MPtr, i::Int64, j::Int64) = GAP.Globals.ELM_LIST(x, i, j)
 Base.setindex!(x::MPtr, v::Any, i::Int64, j::Int64) = GAP.Globals.ASS_LIST(x, i, j, v)
 
 # records
-RNamObj(f::Symbol) = GAP.Globals.RNamObj(MakeString(string(f)))
+RNamObj(f::Union{Symbol,Int64,AbstractString}) = GAP.Globals.RNamObj(MakeString(string(f)))
+# note: we don't use Union{Symbol,Int64,AbstractString} below to avoid
+# ambiguity between these methods and method `getproperty(x, f::Symbol)`
+# from Julia's Base module
 Base.getproperty(x::MPtr, f::Symbol) = GAP.Globals.ELM_REC(x, RNamObj(f))
+Base.getproperty(x::MPtr, f::Union{AbstractString,Int64}) = GAP.Globals.ELM_REC(x, RNamObj(f))
 Base.setproperty!(x::MPtr, f::Symbol, v) = GAP.Globals.ASS_REC(x, RNamObj(f), v)
+Base.setproperty!(x::MPtr, f::Union{AbstractString,Int64}, v) = GAP.Globals.ASS_REC(x, RNamObj(f), v)
 
 #
 Base.zero(x::GAPInputType_internal) = GAP.Globals.ZERO(x)

diff --git a/LibGAP.jl/test/convenience.jl b/LibGAP.jl/test/convenience.jl
@@ -80,4 +80,8 @@ end
     @test record.one == 1
     record.two = 2
     @test record.two == 2
+
+    sym5 = GAP.Globals.SymmetricGroup(5)
+    @test sym5.:1 === GAP.Globals.GeneratorsOfGroup(sym5)[1]
+    @test sym5.:1 === sym5."1"
 end