Update to v4.0.1#11
Open
MaximZimmermannVerve wants to merge 7 commits into
Open
Conversation
Upgrade Dockerfile to use PHP 8.3 and TastyIgniter 4.0, add intl extension, and improve installation steps. Refine .htaccess formatting, update docker-compose and entrypoint script, and revise README with new setup instructions for better clarity and compatibility.
v4.0.0 build
update to v4.0.1
ThisIsQasim
requested changes
Jul 14, 2025
Owner
ThisIsQasim
left a comment
ThisIsQasim
left a comment
There was a problem hiding this comment.
Thanks for the much needed updates. Needs a few changes but otherwise looks good.
| # Use docker.io for Docker Hub if empty | ||
| REGISTRY: docker.io | ||
| # github.repository as <account>/<repo> | ||
| IMAGE_NAME: zimmermannmaxim/tastyigniter |
Owner
There was a problem hiding this comment.
I won't be able to push to your repo
| ``` | ||
| mkdir tastyigniter && cd tastyigniter | ||
| curl -LO https://github.com/ThisIsQasim/TastyIgniter/raw/master/docker-compose.yml | ||
| change the needed settings in the docker-compose using `nano docker-compose.yml` |
Owner
There was a problem hiding this comment.
let people use their preferred text editor
Suggested change
| change the needed settings in the docker-compose using `nano docker-compose.yml` | |
| change the needed settings in the `docker-compose.yml` file |
| docker compose up db -d | ||
| sleep 10 | ||
| docker compose up -d | ||
| docker compose exec app php artisan igniter:passwd admin |
| docker compose up --build -d | ||
| ``` | ||
|
|
||
| Browse to port 8001 of your docker host. The TastyIgniter setup wizard will show up. Wait for a minute for the database container to come up and then run the setup. |
Owner
There was a problem hiding this comment.
is the setup no longer needed as well?
| - DB_DATABASE=tastyigniter | ||
| - DB_USERNAME=tastyigniter | ||
| - DB_PASSWORD=somepassword | ||
| - DB_PASSWORD=securefassword #CHANGEME |
Owner
There was a problem hiding this comment.
Suggested change
| - DB_PASSWORD=securefassword #CHANGEME | |
| - DB_PASSWORD=securepassword #CHANGEME |
| - MYSQL_DATABASE=tastyigniter | ||
| - MYSQL_USER=tastyigniter | ||
| - MYSQL_PASSWORD=somepassword | ||
| - MYSQL_PASSWORD=securefassword #CHANGEME |
Owner
There was a problem hiding this comment.
Suggested change
| - MYSQL_PASSWORD=securefassword #CHANGEME | |
| - MYSQL_PASSWORD=securepassword #CHANGEME |
| # Create .env file with proper values | ||
| if [ -f "/var/www/html/.env.example" ]; then | ||
| echo "Creating .env file..." | ||
| cp /var/www/html/.env.example /var/www/html/.env |
Owner
There was a problem hiding this comment.
it is a bad practice to use .env inside the container. Wouldn't the application pickup env vars from the environment without a separate .env file?
| php artisan key:generate --force | ||
|
|
||
| # Run installation if database is configured | ||
| if [ -n "${DB_HOST}" ] && [ -n "${DB_DATABASE}" ] && [ -n "${DB_USERNAME}" ]; then |
| exec "$@" | ||
| # Configure Apache | ||
| echo "Setting correct DocumentRoot..." | ||
| sed -i 's|DocumentRoot /var/www/html|DocumentRoot /var/www/html/public|g' /etc/apache2/sites-available/000-default.conf |
Owner
There was a problem hiding this comment.
why not do these changes in the Dockerfile rather that at runtime?
Author
|
will have to see if I can find the time to implement the suggested changes as I no longer work with it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.