-
Notifications
You must be signed in to change notification settings - Fork 1
Remove unneeded CI token, enable CodeQL, and add security policy #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is no longer required as the protobuf repo is now public.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good!
466577f
to
6b2acfd
Compare
Preemptively apply known workflow best practices CodeQL will recommend.
6b2acfd
to
76e74e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that now that git checkout replacement config is gone, setting CARGO_NET_GIT_FETCH_WITH_CLI
is most likely also not required anymore.
I'll leave it to you though.
I left it for now as from what I can tell in the docs there are no drawbacks outside perhaps a slight performance impact of forking a new git process instead of using the mechanisms built in to cargo (which may have other optimizations). |
Makes the same change as were done for Go. Note unfortunately CodeQL does not yet support Rust, so this only adds scanning for any issues with GitHub Actions workflows.