Skip to content

Conversation

iamjoemccormick
Copy link
Member

Makes the same change as were done for Go. Note unfortunately CodeQL does not yet support Rust, so this only adds scanning for any issues with GitHub Actions workflows.

This is no longer required as the protobuf repo is now public.
@iamjoemccormick iamjoemccormick added ci/cd Additions or improvements to CI/CD workflows. documentation Improvements or additions to documentation labels Apr 23, 2025
@iamjoemccormick iamjoemccormick self-assigned this Apr 23, 2025
@iamjoemccormick iamjoemccormick requested a review from a team as a code owner April 23, 2025 22:35
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

rustybee42
rustybee42 previously approved these changes Apr 24, 2025
Copy link
Collaborator

@rustybee42 rustybee42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!

rustybee42
rustybee42 previously approved these changes Apr 24, 2025
Preemptively apply known workflow best practices CodeQL will recommend.
Copy link
Collaborator

@rustybee42 rustybee42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that now that git checkout replacement config is gone, setting CARGO_NET_GIT_FETCH_WITH_CLI is most likely also not required anymore.

I'll leave it to you though.

@iamjoemccormick
Copy link
Member Author

I just noticed that now that git checkout replacement config is gone, setting CARGO_NET_GIT_FETCH_WITH_CLI is most likely also not required anymore.

I'll leave it to you though.

I left it for now as from what I can tell in the docs there are no drawbacks outside perhaps a slight performance impact of forking a new git process instead of using the mechanisms built in to cargo (which may have other optimizations).

@iamjoemccormick iamjoemccormick merged commit d074c31 into main Apr 24, 2025
4 checks passed
@iamjoemccormick iamjoemccormick deleted the iamjoe/chore/public-repo-updates branch April 24, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Additions or improvements to CI/CD workflows. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants