Skip to content

refactor: replace mime-types with es-mime-types #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zerob13 merged 1 commit into from
Sep 10, 2025
Merged

refactor: replace mime-types with es-mime-types #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@
"electron-store": "^8.2.0",
"electron-updater": "^6.6.2",
"electron-window-state": "^5.0.3",
"es-mime-types": "^0.1.4",
"fflate": "^0.8.2",
"glob": "^11.0.3",
"https-proxy-agent": "^7.0.6",
"jsonrepair": "^3.13.0",
"mammoth": "^1.10.0",
"mime-types": "^2.1.35",
"nanoid": "^5.1.5",
"ollama": "^0.5.17",
"openai": "^5.18.0",
Expand Down
4 changes: 2 additions & 2 deletions src/main/presenter/filePresenter/FileValidationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { FileAdapterConstructor } from './FileAdapterConstructor'
import { getMimeTypeAdapterMap, detectMimeType } from './mime'
import { UnsupportFileAdapter } from './UnsupportFileAdapter'
import * as mimeTypes from 'mime-types'
import { extension as mimeTypesExtension } from 'es-mime-types'

export interface FileValidationResult {
isSupported: boolean
Expand Down Expand Up @@ -143,7 +143,7 @@ export class FileValidationService implements IFileValidationService {
}

// Get extensions for this MIME type
const extension = mimeTypes.extension(mimeType)
const extension = mimeTypesExtension(mimeType)
if (extension) {
supportedExtensions.add(extension)
}
Expand Down
4 changes: 2 additions & 2 deletions src/main/presenter/filePresenter/mime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { AudioFileAdapter } from './AudioFileAdapter'
import { UnsupportFileAdapter } from './UnsupportFileAdapter'
import fs from 'fs/promises'
import path from 'path'
import * as mime from 'mime-types'
import { lookup } from 'es-mime-types'

export const getMimeTypeAdapterMap = (): Map<string, FileAdapterConstructor> => {
const map = new Map<string, FileAdapterConstructor>()
Expand Down Expand Up @@ -109,7 +109,7 @@ export const getMimeTypeAdapterMap = (): Map<string, FileAdapterConstructor> =>

export const detectMimeType = async (filePath: string): Promise<string> => {
try {
const mimeType = mime.lookup(filePath)
const mimeType = lookup(filePath)
console.log(`[getMimeType] mime.lookup result for ${path.basename(filePath)}:`, mimeType)
if (mimeType) {
console.log('Detected by mime.lookup:', mimeType)
Expand Down